Error trying to access Tour in live demo

rstudio / shinyuieditor

A GUI for laying out a Shiny application that generates clean and human-readable UI code

https://rstudio.github.io/shinyuieditor/

MIT License

209 stars 29 forks source link

Error trying to access Tour in live demo #227

Closed jcheng5 closed 8 months ago

jcheng5 commented 8 months ago

https://rstudio.github.io/shinyuieditor/live-demo/

Select a template, then click the Tour App button.

nstrayer commented 8 months ago

Much like #226 this points to needing e2e tests of the tour mode. This one is due to the tour library using global which, when the editor is embedded as a component into an islands architecture app, doesn't exist like it expects. Should be a fairly easy fix in the build config for the website.

nstrayer commented 8 months ago

Oof, turns out I had already dealt with this. The tour mode uses react-floater which hasn't been updated in a while and relies on webpack conventions of putting in a global variable that would typically just be window. The bandaid is to just assign global to window somewhere before the tour code gets run. I already did this in the main versions of the app in the html template but neglected to do it in the website version. Is fixed in #239.