search

rstudio / shinyuieditor

A GUI for laying out a Shiny application that generates clean and human-readable UI code
https://rstudio.github.io/shinyuieditor/
MIT License
209 stars 29 forks source link

Value box no id bug #241

Closed nstrayer closed 8 months ago

nstrayer commented 8 months ago

Fixes bug from #231 caused by the ValueBox component incorrectly thinking the ValueBox node always had a value node present.

This PR also updates the types for the factory function so this type of bug doesn't happen again. Previously the named arguments object type was being wrapped in a Required<>.

Last, this also adds a placeholder for the value field when it is empty in an attempt to increase discoverability a tiny bit.

netlify[bot] commented 8 months ago

Deploy Preview for shinyuieditor-storybook canceled.

Name Link
Latest commit ae60b3a3f0eb9c7747e61ca584b765973017d879
Latest deploy log https://app.netlify.com/sites/shinyuieditor-storybook/deploys/653acef7aab34f00081dd6f2