search

rstudio / shinyuieditor

A GUI for laying out a Shiny application that generates clean and human-readable UI code
https://rstudio.github.io/shinyuieditor/
MIT License
209 stars 29 forks source link

input/output ID leaked value bug #245

Closed nstrayer closed 8 months ago

nstrayer commented 8 months ago

Due to additional logic added to the input for the ID property for inputs and outputs, when you would switch between two inputs or outputs of the same type (e.g. checkboxGroup) then you would see the previously selected input's ID in place of the current ones. See #243.

This PR fixes that bug by better structuring the hook logic in the InputId component and also adds an e2e test for the scenario to avoid future regressions.

netlify[bot] commented 8 months ago

Deploy Preview for shinyuieditor-storybook ready!

Name Link
Latest commit e3948283350f06524fafbf4a37e72e1517f34ffb
Latest deploy log https://app.netlify.com/sites/shinyuieditor-storybook/deploys/654940406b25980008fa8b88
Deploy Preview https://deploy-preview-245--shinyuieditor-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.