search

rstudio / sortable

R htmlwidget for Sortable.js
https://rstudio.github.io/sortable/
Other
130 stars 30 forks source link

clean up namespaces #18

Closed schloerke closed 5 years ago

schloerke commented 5 years ago

I was under the false impression that the vigs could not be produced without extra packages. With that being wrong, I've removed my extra script and other extra library calls throughout the pkg.

I also rearranged the sortable_js_capture_input to preemptively quit.

codecov-io commented 5 years ago

Codecov Report

Merging #18 into master will decrease coverage by 6.21%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   88.46%   82.24%   -6.22%     
==========================================
  Files           5        5              
  Lines         104      107       +3     
==========================================
- Hits           92       88       -4     
- Misses         12       19       +7
Impacted Files Coverage Δ
R/sortable_list.R 75% <83.33%> (-21.56%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1eec983...4fd0eb7. Read the comment docs.