rstudio / sortable

R htmlwidget for Sortable.js
https://rstudio.github.io/sortable/
Other
130 stars 30 forks source link

Improve bucketable_list() and create parsons() #19

Closed andrie closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #19 into master will increase coverage by 8.54%. The diff coverage is 98.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   82.24%   90.78%   +8.54%     
==========================================
  Files           5        9       +4     
  Lines         107      228     +121     
==========================================
+ Hits           88      207     +119     
- Misses         19       21       +2
Impacted Files Coverage Δ
R/sortable_js.R 77.77% <ø> (ø)
R/incrementor.R 40% <ø> (ø) :arrow_up:
R/sortable_options.R 90.9% <ø> (ø) :arrow_up:
R/sortable_list.R 78.37% <100%> (+3.37%) :arrow_up:
R/css.R 100% <100%> (ø)
R/parsons.R 100% <100%> (ø)
R/learnr.R 92.68% <100%> (ø) :arrow_up:
R/bucketable_list.R 100% <100%> (ø)
R/methods.R 66.66% <66.66%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 66576b5...6d9c6d5. Read the comment docs.

andrie commented 5 years ago

The new proposed format for calling a bucketable list is:

bucketable_list(
    header = "This is a bucketable list. You can drag items between the lists.",
    group_name = "bucketable",
    add_sortable_list(
      text = "Drag from here",
      labels = c("a", "bb", "ccc")
    ),
    add_sortable_list(
      text = "to here",
      labels = NULL
    )
  )

In the code for bucketable_list() it's then quite straight forward to parse the ... dots and modify appropriately.

This commit adds tests for

andrie commented 5 years ago

Merged with 6d9c6d57e2a968cf8603f999df58fc67843f8709