rstudio / sortable

R htmlwidget for Sortable.js
https://rstudio.github.io/sortable/
Other
130 stars 30 forks source link

Change `output_id` to `input_id` #21

Closed andrie closed 5 years ago

andrie commented 5 years ago

Technically we are making an input_id, not setting up the output area for the server to fill out.

andrie commented 5 years ago

Fixing this change also exposed an unintentional bug introduced by 0696d6b8f26e272d5f774f42a4df4d6c0df10f0b. Now that the JavaScript tests if Shiny is running or not, we must provide the input_id when creating a sortable_list.

My next commit will fix this and also use assertthat for handling assertions and checking arguments.