rstudio / sortable

R htmlwidget for Sortable.js
https://rstudio.github.io/sortable/
Other
130 stars 30 forks source link

Use first child id or inner text #40

Closed schloerke closed 5 years ago

schloerke commented 5 years ago

Fixes #33 Fixes #31

@andrie Will need to update gifs on readme with new shiny apps. Feel free to change the apps, just wanted to include htmltools::tags definitions.

codecov-io commented 5 years ago

Codecov Report

Merging #40 into master will increase coverage by 0.78%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   95.51%   96.29%   +0.78%     
==========================================
  Files          10       11       +1     
  Lines         223      270      +47     
==========================================
+ Hits          213      260      +47     
  Misses         10       10
Impacted Files Coverage Δ
R/question_rank.R 94.11% <ø> (ø) :arrow_up:
R/sortable_options.R 100% <100%> (ø) :arrow_up:
R/js.R 100% <100%> (ø) :arrow_up:
R/sortable_js.R 100% <100%> (ø) :arrow_up:
R/rank_list.R 97.56% <100%> (+1%) :arrow_up:
R/bucket_list.R 97.95% <100%> (+0.13%) :arrow_up:
R/dependencies.R 100% <100%> (ø) :arrow_up:
R/label_ids.R 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6668ec...98f4b3f. Read the comment docs.