search

rstudio / sortable

R htmlwidget for Sortable.js
https://rstudio.github.io/sortable/
Other
127 stars 30 forks source link

Update sortable.js to version 1.13.0 #73

Closed msaltieri closed 3 years ago

msaltieri commented 3 years ago

Are you planning to update sortable.js to its latest version? It might help to fix the loss of drag event bug on Safari 13, as explained in this issue.

Is there another way to use current version of sortable with v1.13.0? of sortable.js?

andrie commented 3 years ago

Thanks for reporting. It's quite straight-forward to include a new version of sortable.js and I've created a branch called sortablejs-1.13 and a PR #74 to test this.

Please can you checkout this branch and let me know if everything works as expected?

remotes::install_github("rstudio/sortable@sortablejs-1.13")
msaltieri commented 3 years ago

Hi @andrie thanks for your quick answer. I've just tested your sortablejs-1.13 branch and I can confirm the loss of drag event bug is fixed.

Are you planning to release a new version of sortable with this enhancement?

andrie commented 3 years ago

I didn't have plans to release a new version, but this upgrade would be a good reason to accelerate creating a new version.

Thanks for testing :-)

msaltieri commented 3 years ago

If I can help testing or writing part of the code, just get in touch. It would be a pleasure.