search

rstudio / tfestimators

R interface to TensorFlow Estimators
https://tensorflow.rstudio.com/tfestimators
57 stars 21 forks source link

Support for boosted trees estimators #146

Closed terrytangyuan closed 6 years ago

terrytangyuan commented 6 years ago

BoostedTreesClassifier and BoostedTreesRegressor are now indeed available in core here.

@kevinykuo Let's use this issue to track progress since https://github.com/rstudio/tfestimators/issues/40 is only used for personal tracking of various upstream changes.

kevinykuo commented 6 years ago

Taking a stab at this.

kevinykuo commented 6 years ago

@terrytangyuan Currently I think there's a problem with the gradient calculation not liking integer labels. Here's the proposed fix https://github.com/tensorflow/tensorflow/compare/master...kevinykuo:bugfix/boosted-trees-labels-cast -- could you take a look to see if it makes sense before I send it in? (Python noob here!)

terrytangyuan commented 6 years ago

The change looks good to me. Let's see if TF team has any comments on it (they may have some internal requirement regarding the performance).