search

rstudio / tfhub

R interface to TensorFlow Hub
28 stars 7 forks source link

Exported and documented methods. #24

Closed jonthegeek closed 3 years ago

jonthegeek commented 3 years ago

Please correct this if this isn't the preferred method for exporting methods (I've never been 100% clear about that so I'm anxious to learn)!

This doesn't completely deal with #23, but it at least makes the examples work as expected.

dfalbel commented 3 years ago

Hey @jonthegeek!

Thanks very much!

In theory, the current dev version should already be correctly exporting the methods with:

https://github.com/rstudio/tfhub/blob/52410fe7f4fc869c2e9a340741d8a7d8afe02916/R/package.R#L12-L13

We prefer dynamically exporting to not take dependency on recipes which is quite heavy. Are you using the dev version in your example in #23?

jonthegeek commented 3 years ago

Doh, I didn't try the dev branch, my mistake! That's a good trick to learn, glad to see it!