search

rstudio / thematic

Theme ggplot2, lattice, and base graphics based on a few simple settings.
https://rstudio.github.io/thematic/
Other
244 stars 10 forks source link

GHA v2 #116

Closed schloerke closed 2 years ago

schloerke commented 2 years ago

Related #115

Carson: We should remove the GHA branches and extra logic as snapshots have been ported from vdiffr to testthat

cpsievert commented 2 years ago

I think {shiny-workflows} might need brew install pkg-config on Mac?

https://github.com/rstudio/thematic/runs/4217003066?check_suite_focus=true#step:3:1022 https://github.com/r-spatial/sf#macos

schloerke commented 2 years ago

🙌 Thank you!

schloerke commented 2 years ago

Added fix: https://github.com/rstudio/shiny-workflows/commit/49413ac003f869f079f424ce1045b9f0a6e16884 ** Re-running jobs

schloerke commented 2 years ago

@cpsievert macOS now passes 🥳 . Related: 56e4b0e0e08b7bcf06861588b3515ebd26c240cf...ae73d26d34c02d763be9172eb85ee372a8e5c8a3#diff-7d5f60492f

schloerke commented 2 years ago

Merging as Windows tests are failing due to s2 which has been fixed on GitHub