Closed cderv closed 2 years ago
naveen521kk
commented
2 years ago I modified it so that we only test the built source package. Do I need to revert back ?
Looks good. Actually, the additional source to their community repository would be required if the package had any dependencies; but it doesn't have so it should work with just ..
cderv
commented
2 years ago @yihui one question: Build TinyTeX-2 version, so the full scheme, is just a matter of running tlmgr install scheme-full, then creating the bundle ?
I mean it could be in fact a step in our existing daily workflow in https://github.com/yihui/tinytex/blob/main/.github/workflows/build.yaml ?
Am I right ?
I am asking as I reworked the daily workflow using the new gh release edit feature, and I believe we could merge everything there for daily release as discussed. I want to be sure I got it right.
Can you confirm ? Thanks!
yihui
commented
2 years ago I mean it could be in fact a step in our existing daily workflow in https://github.com/yihui/tinytex/blob/main/.github/workflows/build.yaml ?
Yes, it could be a step there. I think that will be simpler.
cderv
commented
2 years ago Yes, it could be a step there. I think that will be simpler.
Yes it definitely will be. I am taking more time that I thought on this, but once that will be in place, it should work for a long time (hopefully). I am almost there! I need gh CLI 2.8 on windows runner now 😅 too recent
cderv
commented
2 years ago I have now moved the daily build of scheme-full in the tinytex repo with other daily build version.
This repo will now only contains monthly build, and patch version builds, with chocolatey packaging and publishing.
I'll merge this one as soon as the other is merged.
cderv
commented
2 years ago I have added a better description of what value to set, and also a new inputs for not deploying to choco if we want to build a patch version without deploying
yihui
commented
2 years ago Sounds good!
cderv
commented
2 years ago I ran the new workflow on tinytex to build a daily manually and this is working https://github.com/yihui/tinytex/actions/runs/2220702807 published the new https://github.com/yihui/tinytex-releases/releases
I'll merge this and try a patch release to check it is working
cderv
commented
2 years ago Can you give me correct access also in this repo ? For whatever reason I don't see an Action tab... Maybe it needs to be activated ? I found the url works though: https://github.com/cderv/test-actions/action
cderv
commented
2 years ago And it works ! 🎉
See https://github.com/yihui/tinytex-releases/actions/runs/2221722638
I did the final test in "master" as it was easier to check bu reverted the tag, test patch release and commit.
Everything is good for next month !
yihui
commented
2 years ago Can you give me correct access also in this repo ? For whatever reason I don't see an Action tab... Maybe it needs to be activated ?
I don't know why that happens, but I don't have an option to change your role in this repo or activate the Actions tab specifically. Can you see the Actions tab now?
Everything is good for next month !
Perfect! Thanks!
cderv
commented
2 years ago I don't know why that happens, but I don't have an option to change your role in this repo or activate the Actions tab specifically. Can you see the Actions tab now?
No I don't see it. That is odd... I'll look on the web for information. I can access the tab using url directly so I am not blocked
yihui
commented
2 years ago That's really odd. I tried other web browsers and I was able to see the tab no matter if I'm logged in or not.
cderv
commented
2 years ago Got an idea. I'll check something ...
cderv
commented
2 years ago Yeah I think this is an issue in Refined GitHub extension. I'll fill an issue there. Sorry for the trouble
cderv
commented
2 years ago I had to tweak a little the PR in 507893d08b090e05be6bd53a6c87149c3568b855 and 170c508fb3d6d188cfeb57765163e2f6d921ba6b so that the publishing to chocolatey works.
I manually triggered this month build also because schedule was for next mont in fact. Starting in JUNE, this should all work fine automatically
yihui
commented
2 years ago Sounds good. Thank you!
This aims to replace appveyor build.
I am opening this PR so that you can have a look at the change and give some feedback. Here is the details:
Current proposal:
We split the process into 3 workflows:
tinytexrepoSo basically the workflow would be :
Daily builds are done in the
tinytexrepo and a new daily release is created with new assetsWhen this is done sucessfully, it will trigger the daily workflow here to build the daily full bundle and it will update the daily release by adding the missing assets.
Every first of the month, the monthly workflow would run and will download every assets of the last daily release.
It will keep the TinyTeX bundles and adds a vYYYY-MM to the name.
The choco configuration will be updated and a new tag will be created.
A new release is created with all the assets
As last step, the workflow to update choco package will be triggered to build and publish the package.
I have tested all this in my fork, hence the reference to my repos in this PR. I left it as is in the draft PR and modified if everything is ok. Also, the choco publishing if deactivated for now. Setting the API KEY
CHOCO_KEYin the repo secret will be necessaryTest of releases are here: https://github.com/cderv/tinytex-releases/releases
Also some
.shfiles have been removed - are you using them elsewhere ?A few questions:
How do we want to handle the fact that daily version will not have TinyTeX-2 until it is build here and added to the daily release ?
Do we want to publish a new choco package when doing a patch version ?
Was this
--sourceargument necessary ? https://github.com/yihui/tinytex-releases/blob/ba3b3d33901085f01f639857da1aa2e0b20a0f99/appveyor.yml#L67 I modified it so that we only test the built source package. Do I need to revert back ?I did not test to install one of the bundle yet, but I think it will work. I'll do that next week.