Closed ganesh-k13 closed 1 year ago
Welcome Ganesh! Thank you so much for this contribution, and it was great to meet you at PyData NYC. :)
I think _model_meta
is the correct spot for this, since the user section on a VetiverModel should be user-given metadata. I'm currently working on a metadata refactor in #126 that should make the addition of new fields a lot easier (and clean out the user
field). Once that PR is in, let's look at adding python_version
to _model_meta
!
Ah that makes sense, thanks for the info! Will keep an eye out for that PR and rebase when done. Will keep looking around other stuff in the project meanwhile :+1:
Ah that makes sense, thanks for the info! Will keep an eye out for that PR and rebase when done. Will keep looking around other stuff in the project meanwhile 👍
Hi Ganesh-- the other PR (#126) has been merged! It should be easier to add the Python version to the metadata dataclass now :)
Thanks! Sorry was not active, had a few ideas but got caught up. I'll try to finish it this week.
Changes
This adds the python system information to the metadata
Note
Hey folks! I found your repo through PyData NYC and was interested in contributing mainly to the deployment aspect. This is a basic PR for one of the issues to get a hang of the project.
Testing:
~There is no UT :)~ It's inside another folder, my bad Sample run:
Alternatively
We could add it to _model_meta to make it global? Seemed too invasive so wanted a second opinion
resolves: #115