search

rstudio / vetiver-python

Version, share, deploy, and monitor models.
https://rstudio.github.io/vetiver-python/stable/
MIT License
59 stars 17 forks source link

[DOCS] update docs to look less like vetiver.rstudio.com #178

Closed isabelizimm closed 1 year ago

isabelizimm commented 1 year ago

After gathering community feedback, we may have made too unified of a look between the Python package docs and vetiver.rstudio.com. This PR is to update the look as well as add in links to the R package docs

isabelizimm commented 1 year ago

@machow any quick guesses as to why quartodoc isn't able to render VetiverModel anymore? maybe something to pair on to clean everything up/think about debugging strategies, since I know you've been making lots of big moves in quartodoc land!

juliasilge commented 1 year ago

You can see the (minor) changes I made to the R pkgdown site navbar here now: https://rstudio.github.io/vetiver-r/dev/

isabelizimm commented 1 year ago

HMMMM what is happening in this Docs Check 😩

has2k1 commented 1 year ago

HMMMM what is happening in this Docs Check 😩

I think there is a missing secret token.

isabelizimm commented 1 year ago

HMMMM what is happening in this Docs Check 😩

I think there is a missing secret token.

Yeah, the deployment_id is missing because the docs are breaking upon build (a successful docs build will populate this ID). I had installed off a branch of quartodoc locally and am using some new/not backwards compatible features, so I'll plan to rerun and merge this PR on quartodoc's next release!

machow commented 1 year ago

I don't think we were able to locally reproduce this specific error last week when pairing (but were able to generate the site locally), so am a bit stumped on what might be going on. Maybe we can take a pass when pairing on Tues, and try updating all requirements?

isabelizimm commented 1 year ago

I don't think we were able to locally reproduce this specific error last week when pairing (but were able to generate the site locally), so am a bit stumped on what might be going on. Maybe we can take a pass when pairing on Tues, and try updating all requirements?

Yeah, this sounds good to me!