rstudio / vetiver-python

Version, share, deploy, and monitor models.
https://rstudio.github.io/vetiver-python/stable/
MIT License
59 stars 17 forks source link

maint: remove `root_path` usage in `TestClient` #207

Closed isabelizimm closed 5 months ago

isabelizimm commented 7 months ago

With fastapi==0.109.0/ starlette==0.35.0, there have been breaking changes to how root_path is used within APIs. While vetiver doesn't use this directly, it is the way test paths are set inside TestClient, so many of our tests are failing.

from https://github.com/encode/starlette/pull/2400

... if it [root_path] is set, it will be passed to the ASGI apps, that will internally extract/remove it from the paths. But clients communicating with those ASGI apps, if they are indeed mounted at the defined root_path, would have to communicate with it using the root_path prefix. So this PR updates the client to actually require/use that, clients created with root_path would need to be used the same way that clients communicating with those ASGI apps mounted at some prefix path.