rstudio / vetiver.posit.co

Website for the vetiver 🏺 framework
https://vetiver.posit.co/
12 stars 8 forks source link

filing this to keep track of gaps in the tab syncing! #4

Closed dpastoor closed 2 years ago

dpastoor commented 2 years ago
juliasilge commented 2 years ago

Here is some slightly weird behavior to address:

Now neither the R or Python tab is selected. If you click somewhere else (like to "Version") not only is neither R nor Python selected, but there is no content displayed in any of the tabs.

dpastoor commented 2 years ago

hmmm I get partial replication - definitely something going on

dpastoor commented 2 years ago

replication of the issue

https://user-images.githubusercontent.com/3196313/168491161-6568667c-2f82-4cfa-bcc9-67a2aa0fbbfd.mov

juliasilge commented 2 years ago

I can also see this behavior (tabs blanking out with neither selected) if I:

dpastoor commented 2 years ago

ok - the issue seems to stem from the fact that when doing that backwards navigation none of the panels seem to be selected (not even a default), hence all that lower content is also hidden. What I'm not sure of just yet is whether this is a quarto bug that would happen on any website, or something that the custom script is exacerbating.

dpastoor commented 2 years ago

need more precise targeting - tabset is not specific enough in the existing code. For example:

image

inside also has an id that starts with tabset (that improperly then gets applied active when clicked too)

image

hopefully can use some of the additional ID's to more precisely target