search

rstudio / websocket

WebSocket client for R
https://rstudio.github.io/websocket/
Other
92 stars 19 forks source link

Fixes for CRAN #109

Closed wch closed 1 month ago

wch commented 1 month ago

This PR addresses the following issues:

Result: WARN 
  Found the following significant warnings:
    ./lib/websocketpp/logger/basic.hpp:61:49: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ./lib/websocketpp/logger/basic.hpp:67:35: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ./lib/websocketpp/logger/basic.hpp:72:30: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ./lib/websocketpp/logger/basic.hpp:78:30: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ./lib/websocketpp/logger/basic.hpp:84:5: warning: template-id not allowed for destructor in C++20 [-Wtemplate-id-cdtor]
    ./lib/websocketpp/logger/basic.hpp:87:30: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ./lib/websocketpp/logger/basic.hpp:100:30: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ./lib/websocketpp/endpoint.hpp:112:5: warning: template-id not allowed for destructor in C++20 [-Wtemplate-id-cdtor]
  See ‘/data/gannet/ripley/R/packages/tests-devel/websocket.Rcheck/00install.out’ for details.
Result: NOTE 
  File 'websocket/libs/x64/websocket.dll':
    Found non-API calls to R: 'R_nchar', 'Rf_findVarInFrame3',
      'SETLENGTH', 'SET_GROWABLE_BIT', 'SET_TRUELENGTH'

  Compiled code should not call non-API entry points in R.

  See 'Writing portable packages' in the 'Writing R Extensions' manual,
  and section 'Moving into C API compliance' for issues with the use of
  non-API entry points.