rstudio / websocket

WebSocket client for R
https://rstudio.github.io/websocket/
Other
92 stars 19 forks source link

Add support for connecting to websocket through proxy #96

Open TobiasMadsen opened 2 years ago

TobiasMadsen commented 2 years ago

This pull request exposes three new parameters to the websocket constructor:

An alternative approach would be to check and respect the settings given by thehttp_proxy, https_proxy environment variables. However, some proxies do not support websockets, so this might leave some users in a bad state, where they have to change these environment variables back and forth when connecting to the websocket.

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

TobiasMadsen commented 2 years ago

Hi, I have sent the contributor agreement by mail. Best, Tobias

Syntopia commented 1 year ago

This would be great to have fixed (including Skjernaa's fix above). Any progress here?