rstudio4edu / rstudio4edu-book

Organizing rstudio4edu project progress
https://rstudio4edu.github.io/rstudio4edu-book/
66 stars 34 forks source link

Alison edits round1 #8

Closed apreshill closed 5 years ago

apreshill commented 5 years ago

Hey @dcossyleon,

I think this can be safely merged in. It should look like this:

https://quirky-liskov-be449b.netlify.com/

A few things to note:

  1. I wonder if we want to do any CSS styling more with the TOC now that we have sections vs chapters (should sections perhaps be uppercase, then chapters in title case? I defer to you, but right now it is the opposite.

  2. Also I did sort of a trick with a lot of those "intro" chapters. We could do some CSS with first of type selectors to perhaps indent those, italicize, or otherwise denote those differently. They are currently just unnumbered, but hoping you might have some ideas.

  3. I added some divs to the css for better tip/note/warning boxes (issue #3). I copied over the ones from the current R packages book, so please style away. Also I think we cannot use the lightbulb image as it needs attribution. But the setup is now there for you. See them in action here; code here. You can literally change anything about these- and add more as you think appropriate (right now there are just two: rstudio-tips and tips).

  4. I was wondering if you might want to reconsider some kind of image at the top of each chapter? You could either do full width with some css magic, or you could do includes: before_body instead of in_header option (link). Up to you, but I still love that image and miss it!

  5. Finally, I added a folder called modules/ where you could (if you wanted to) store individual Rmd docs to be used as child documents to the bookdown parent versions (link). See an example here.

dcossyleon commented 5 years ago

My questions/ comments below:

  1. I wonder if we want to do any CSS styling more with the TOC now that we have sections vs chapters (should sections perhaps be uppercase, then chapters in title case? I defer to you, but right now it is the opposite.
  1. Also I did sort of a trick with a lot of those "intro" chapters. We could do some CSS with first of type selectors to perhaps indent those, italicize, or otherwise denote those differently. They are currently just unnumbered, but hoping you might have some ideas.
  1. I added some divs to the css for better tip/note/warning boxes (issue #3). I copied over the ones from the current R packages book, so please style away. Also I think we cannot use the lightbulb image as it needs attribution. But the setup is now there for you. See them in action here; code here. You can literally change anything about these- and add more as you think appropriate (right now there are just two: rstudio-tips and tips).
  1. I was wondering if you might want to reconsider some kind of image at the top of each chapter? You could either do full width with some css magic, or you could do includes: before_body instead of in_header option (link). Up to you, but I still love that image and miss it!
  1. Finally, I added a folder called modules/ where you could (if you wanted to) store individual Rmd docs to be used as child documents to the bookdown parent versions (link). See an example here.