rsuite / schema-typed

Schema for data modeling & validation
MIT License
198 stars 28 forks source link

fix: nested objects returned checkResult, execution of async rules on arrays #75

Open giacomoaugello1 opened 6 months ago

giacomoaugello1 commented 6 months ago
giacomoaugello1 commented 4 months ago

Hi Simon,

I apologize for not making the changes you requested; I've been quite busy during this period.

I noticed that you committed some changes to fix nested object-related bugs, and I see that you used some parts of my code. Have you also addressed the issue related to async checks for ArrayType.of(...)?

I don’t have time to test it. Please let me know.

Best regards,

Giacomo Augello

On 8 Apr 2024, at 03:56, Simon Guo @.***> wrote:

@simonguo requested changes on this pull request.

In test/ArrayTypeSpec.js https://github.com/rsuite/schema-typed/pull/75#discussion_r1555147459:

  • resolve(true);
  • }, 1000);
  • });
  • }, 'error2'),
  • });
  • schema.checkAsync({ arr1: [1, 2, 3], arr2: [1, 2, 3] }).then(status => {
  • if (
  • status.arr1.hasError &&
  • status.arr1.errorMessage === 'error1' &&
  • !status.arr2.hasError
  • ) {
  • done();
  • }
  • });
  • }); }); Code added in ArrayType().of, but missing tests for it.

— Reply to this email directly, view it on GitHub https://github.com/rsuite/schema-typed/pull/75#pullrequestreview-1985332587, or unsubscribe https://github.com/notifications/unsubscribe-auth/APS5OMPSSLVEAXCJZBURRGLY4H2L7AVCNFSM6AAAAABE2L7HSGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOBVGMZTENJYG4. You are receiving this because you authored the thread.