rsx-labs / aide-frontend

This is the repository for AIDE
https://rsx-labs.github.io/aide-frontend/
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

[Log in/out] How to handle if employee works past midnight #673

Open charissasylim opened 4 years ago

charissasylim commented 4 years ago

Describe the bug Right now, If an employees logs out past midnight the log out time gets displayed on the next day together with time for login also. Attendance shows 2 time past 12 midnight.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Version (please complete the following information):

Additional context Add any other context about the problem here.

charissasylim commented 4 years ago

@chriscg @trashvin This needs redesign on where to get the time in from. Per Chris, this is based on windows login time but from my experience, it seems to be getting time when AIDE is started on the machine.

charissasylim commented 4 years ago

@chriscg @trashvin For time in as discussed wtih @trashvin ,

  1. Get system event ID 1 (time when laptop is turned on)
  2. If not found, use @chris current logic which gets Security event 4624 (said to be the time when user logs in to windows)
  3. If not found, get current time (AIDE run time)
charissasylim commented 4 years ago

Caused issue #699

trashvin commented 4 years ago

Temporarily disabling check for 4624 that causes exception due to access violation. Lets keep this open.