search

rsyi / whale

🐳 The stupidly simple CLI workspace for your data warehouse.
https://rsyi.gitbook.io/whale
GNU General Public License v3.0
724 stars 38 forks source link

Fix Slack tests #167

Closed peterthesling closed 3 years ago

peterthesling commented 3 years ago

When CI ran in an earlier merge, it failed. From https://github.com/dataframehq/whale/runs/2622524391:

>           raise RuntimeError(_request_ctx_err_msg)
E           RuntimeError: Working outside of request context.
E           
E           This typically means that you attempted to use functionality that needed
E           an active HTTP request.  Consult the documentation on testing for
E           information about how to avoid this problem.

Locally I was never able to reproduce the error, but it seems that we need to create a Flask context first to access anything about the request. This is done with test_request_context. Since this environment is even more contained, I think the only way to test code is to manually call the method being called on this specific route.

codecov-commenter commented 3 years ago

Codecov Report

Merging #167 (1402cdd) into master (8b4917c) will increase coverage by 1.29%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   74.09%   75.39%   +1.29%     
==========================================
  Files          35       39       +4     
  Lines        1915     2073     +158     
==========================================
+ Hits         1419     1563     +144     
- Misses        496      510      +14
Impacted Files Coverage Ξ”
pipelines/whale/utils/__init__.py 70.96% <0.00%> (-15.83%) :arrow_down:
pipelines/whale/__init__.py 60.63% <0.00%> (-1.22%) :arrow_down:
pipelines/whale/utils/parsers.py 94.80% <0.00%> (-1.15%) :arrow_down:
pipelines/whale/utils/paths.py 100.00% <0.00%> (ΓΈ)
pipelines/whale/utils/markdown_delimiters.py 100.00% <0.00%> (ΓΈ)
...hale/extractor/base_postgres_metadata_extractor.py 85.71% <0.00%> (ΓΈ)
pipelines/whale/extractor/base_index_extractor.py 100.00% <0.00%> (ΓΈ)
pipelines/whale/models/index_metadata.py 100.00% <0.00%> (ΓΈ)
...elines/whale/extractor/postgres_index_extractor.py 93.54% <0.00%> (ΓΈ)
...nes/whale/extractor/redshift_metadata_extractor.py 88.88% <0.00%> (ΓΈ)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 8b4917c...1402cdd. Read the comment docs.