rsyncOSX / RsyncUI

A SwiftUI based macOS GUI for rsync.
https://github.com/rsyncOSX
MIT License
265 stars 9 forks source link

Application hangs if rsync cannot be found #24

Closed expiredemulsion closed 2 months ago

expiredemulsion commented 2 months ago

I have the rsync binary installed at: /usr/local/bin/ and tried to direct RsyncUI to use that path but upon running or estimating in RsyncUI, I get the message: "The file "rsync" doesn't exist. The file doesn't exist."

Then RsyncUI hangs for ever and need to be forcefully terminated.

RsyncUI crashlog.txt

rsync version 3.3.0pre1-7-g2f9b963a protocol version 31 RsyncUI 2.0.0

rsyncOSX commented 2 months ago

I will check it out :-) long time ago since I used other paths than default for rsync. I will check the code now and make an update to solve the issue...

rsyncOSX commented 2 months ago

I have discovered why it hangs... I will make an update later this evening, thx for reporting the issue..

expiredemulsion commented 2 months ago

Great to hear. Thanks for such swift correction.

rsyncOSX commented 2 months ago

I will make an update for you to test in some hours. I am just about to leave my cabin in the mountains.. It is some hours driving home and I have to verify the changes as well before making a new version for you to test...

rsyncOSX commented 2 months ago

Just updated the version 2.0.0 rc. There is a fix for the issue. To reset any wrong rsync paths to default value, toggle version of rsync. RsyncUI now will start with no valid rsync in path. It also shows no valid rsync if true when RsyncUI start. Thx very much for reporting the issue.

expiredemulsion commented 2 months ago

Hello Do the 2.0.0 b101 build contain the fix?

I'm still getting hangs when trying to open the preferences to change the paths. The preferences pane opens behind the main screen but the notice about "The file "rsync" doesn't exist." is placed ontop and then the applications hangs.

rsyncOSX commented 2 months ago

Hello Do the 2.0.0 b101 build contain the fix?

I'm still getting hangs when trying to open the preferences to change the paths. The preferences pane opens behind the main screen but the notice about "The file "rsync" doesn't exist." is placed ontop and then the applications hangs.

That is kind of weird, it should not hang. Yes, the new rc (2.0.0. b101) includes the fix. I suggest you just delete the settings file, see here where it is: https://rsyncui.netlify.app/post/configfiles/ and restart RsyncUI. RsyncUI then starts with default configs.

rsyncOSX commented 2 months ago

And by toggling the Rsync v3.x in settings, resets any user settings for rsync (reset to default settings). I have no rsync in /usr/local/bin - only Homebrew version for Mac Silicon ..

Screenshot 2024-08-13 at 19 35 55 Screenshot 2024-08-13 at 19 36 11