search

rsyslog / liblognorm

a fast samples-based log normalization library
http://www.liblognorm.com
GNU Lesser General Public License v2.1
99 stars 64 forks source link

annotate: inline comments not properly treated #225

Closed rgerhards closed 7 years ago

rgerhards commented 7 years ago

In a line like this:

annotate=tag:+data="something" # a comment

the comment is not detected as such and instead leads to "invalid opcode" error, which causes the annotate to not be loaded. Due to #224, the problem is not even reported to the user.

rgerhards commented 7 years ago

I need to corrrect the bug tracker a bit. The documentation explicitely states that comments MUST start in the first column, so inline comments are actually not supported. They cannot be used in most types of statements, as the comment char could be just a regular part of the rule. However, for annotations this is possible, and for ease of use we should accept this.