rsyslog / liblognorm

a fast samples-based log normalization library
http://www.liblognorm.com
GNU Lesser General Public License v2.1
99 stars 64 forks source link

LOGNORMALIZER::CHANGED:: when using '-V' flag, return 0 (zero) when program exits #365

Open frikilax opened 1 year ago

frikilax commented 1 year ago

Description

When printing lognormalizer's version through its '-V' flag, the return code is not zero, that return code is counter intuitive and prevents using the command in scripts and/or CI/CD frameworks

Changed

rgerhards commented 1 year ago

oops... that sounds indeed bad.

I would say this does not case a real backwards-compatibilty issue as the tool itself is not used that often. @davidelang what do you think (we are talking about the stand-alone tool, not the rsyslog integration)?

davidelang commented 1 year ago

sounds like a mistake, and one that it's very unlikely that anyone is going to depend on, so I would say it's reasonable to fix it.

David Lang

On Thu, 13 Oct 2022, Rainer Gerhards wrote:

oops... that sounds indeed bad.

I would say this does not case a real backwards-compatibilty issue as the tool itself is not used that often. @davidelang what do you think (we are talking about the stand-alone tool, not the rsyslog integration)?

rgerhards commented 1 year ago

@davidelang thx!