search

rsyslog / librelp

OFFICIAL librelp repository on github
https://www.rsyslog.com/librelp/
GNU General Public License v3.0
30 stars 35 forks source link

relp session: Add API function to enable/disable Relp Client AutoRetry feature #234

Closed alorbach closed 1 year ago

alorbach commented 3 years ago

The feature controls if a relp session can automatically be reestablished automatically. Tests are difficult to make in librelp testbench, so it makes more sense to create them in rsyslog in a later step.

closes: https://github.com/rsyslog/librelp/issues/223

rgerhards commented 3 years ago

I wonder what the use case for this feature is? I mean the point of RELP is to prevent loss, but without proper reestablishment, it cannot do that...

alorbach commented 3 years ago

It was implemented long long time ago: https://github.com/rsyslog/librelp/commit/f7dee6f54bbd8dc25b0da373a5816dbce944307d https://github.com/rsyslog/librelp/commit/fc1721812c27319af116b361cd3af6b785c31957

Perhaps the options can be removed then and the autoretry behavior be made static?

rgerhards commented 1 year ago

After discussion, we came to the conclusion that this feature is not useful. The original implementation seems to have been an (unfinished) experiment, which we will remove.

rgerhards commented 1 year ago

replaced by https://github.com/rsyslog/librelp/pull/252