rsyslog / librelp

OFFICIAL librelp repository on github
https://www.rsyslog.com/librelp/
GNU General Public License v3.0
30 stars 35 forks source link

librelp hardening: Fix multiple minor issues causing debugging trouble #239

Closed alorbach closed 1 year ago

alorbach commented 2 years ago
rgerhards commented 2 years ago
  • move receive buffer in relpSessRcvData to dyn memory (Stack before)

do we necessarily need this? I ask because that results in worse performance.

alorbach commented 2 years ago

While trying to find a rootcause of overwritten stack memory, I switched this to dynamic memory so at least chances of getting code memory corrupted get lower. Also on systems with lower stack memory available (like IOT devices), dynamic memory would be a better option. I can switch back to stack memory if you have performance concerns.