Closed StrongestNumber9 closed 1 year ago
You are not using TLS? That's more than strange. Can you send me the config and a debug log at least covering the complete startup?
TLS is not used in imrelp or omrelp but it is enabled for imtcp. Added rsyslog.conf and debug log for startup in the support ticket
Would it be possible that your run rsyslog under valgrind control and provide us the resulting valgrind exceptions? If we have bad luck, the problem does not occur. But if it does, valgrind often provides very useful information.
Well, I looked once again at the code that I am suspecting to be not OK. Question: did you compile librelp with or without TLS?
@StrongestNumber9 I have crafted a draft PR (#241), but I am not really convinced it will address your issue. If you have the time, it would be good if you could give it a try.
Well, I looked once again at the code that I am suspecting to be not OK. Question: did you compile librelp with or without TLS?
We didn't set any other options explicitly except --prefix=/our/path
and --disable-static
14:57:03 [INFO] librelp will be compiled with the following settings:
14:57:03 [INFO]
14:57:03 [INFO] run valgrind in testbench: yes
14:57:03 [INFO] Debug mode enabled: no
14:57:03 [INFO] GNUTLS enabled: yes
14:57:03 [INFO] GNUTLS authentication supported: yes
14:57:03 [INFO] OPENSSL enabled: yes
14:57:03 [INFO] generic TLS tests enabled: yes
14:57:03 [INFO] Debug mode enabled: no 14:57:03 [INFO] GNUTLS enabled: yes 14:57:03 [INFO] GNUTLS authentication supported: yes 14:57:03 [INFO] OPENSSL enabled: yes
Looks like enabled
. I admit that I am puzzled by the issue you see. Could you still try out the patch I posted? Frankly, I don't think it cures your problem, but knowing that would really help (at least me).
We compiled rsyslog with --enable-openssl --disable-gnutls
in addition to librelp with --disable-tls --enable-tls-openssl
settings and that seems to fix the problem or at least allows us to stay afloat. Haven't been able to test the patch yet as this is kinda do-or-die situation at clients production so minimal disruptions right now
@StrongestNumber9 Thx for the feedback and glad to hear you have a work-around. Given that, I plan to look more in-depth next week together with @alorbach. I am pretty sure that there is a bug, but I do not clearly see the bug area. My guess is that a full analysis takes me to the beginning of next week as well, so there is not much benefit in doing it right now, quite frankly said,
We are getting segmentation faults related to relp handling
Backtrace from the dump
We are getting this many times per day and we are not using tls here. We have coredumps available if needed. We also see messages from https://github.com/rsyslog/librelp/blob/v1.10.0/src/relpframe.c#L189-L195 before segfaulting. We use 256k maxMessageSize on rsyslog configuration.