search

rsyslog / librelp

OFFICIAL librelp repository on github
https://www.rsyslog.com/librelp/
GNU General Public License v3.0
30 stars 36 forks source link

Protocol documentation fix #257

Open thierry-f-78 opened 1 year ago

thierry-f-78 commented 1 year ago

Hi,

I'm currently regarding to implement RELP server. I'm processing offer message.

I see in the doc this definition of offer message:

OFFER = LF FEATURENAME ["=" VALUE *("," VALUE)]

But, I do not constat this format in practice with rsyslog client. It seems the LF char is added at the end of message only if it is not the last message.

https://github.com/rsyslog/librelp/blob/master/src/offers.c#L355

I suggest to update doc like this:

OFFERLIST = OFFER *( LF OFFER )
OFFER = FEATURENAME ["=" VALUE *("," VALUE)]

According with doc, at least one offer is mandatory (relp_version) so the ABNF below describe this.

Thierry