Closed Yashinde145 closed 1 year ago
@rgerhards Please review the PR.
This sounds OK and I appreciate the patch. Just curios: what is the core reason for patching this? Is it "just" to do the right thing, or did you experience any erros/annoyances? Would be good to know as I do not see any issues, also not in CI.
As mentioned in issue #256, the error was found for inlining functions in Yocto librelp sources for DEBUG build. Thanks for reviewing.
Hi @rgerhards, I think the centos 8 and fedora 36 checks did not initiate. Can you please re-run it?
I'll check what's going on.
I think I know what is wrong with the two failing CI runs. The workflow has too-old ubuntu versions specified. I think it is OK to merge without them. Will also check and see that I can fix the CI issue.
FYI The CI issue is fixed via #259. But I don't see any reason to rebase and re-run CI.
Thx again for the PR! Much appreciated.
Thanks for checking and accepting PR!
Compiler does not inline any functions when using debug optimization (-Og). Hence, remove -Winline flag when compiling with debug optimization.