search

rsyslog / librelp

OFFICIAL librelp repository on github
https://www.rsyslog.com/librelp/
GNU General Public License v3.0
30 stars 35 forks source link

Fix function inline errors in debug optimization (-Og) #258

Closed Yashinde145 closed 1 year ago

Yashinde145 commented 1 year ago

Compiler does not inline any functions when using debug optimization (-Og). Hence, remove -Winline flag when compiling with debug optimization.

Yashinde145 commented 1 year ago

@rgerhards Please review the PR.

rgerhards commented 1 year ago

This sounds OK and I appreciate the patch. Just curios: what is the core reason for patching this? Is it "just" to do the right thing, or did you experience any erros/annoyances? Would be good to know as I do not see any issues, also not in CI.

Yashinde145 commented 1 year ago

As mentioned in issue #256, the error was found for inlining functions in Yocto librelp sources for DEBUG build. Thanks for reviewing.

Yashinde145 commented 1 year ago

Hi @rgerhards, I think the centos 8 and fedora 36 checks did not initiate. Can you please re-run it?

rgerhards commented 1 year ago

I'll check what's going on.

rgerhards commented 1 year ago

I think I know what is wrong with the two failing CI runs. The workflow has too-old ubuntu versions specified. I think it is OK to merge without them. Will also check and see that I can fix the CI issue.

rgerhards commented 1 year ago

FYI The CI issue is fixed via #259. But I don't see any reason to rebase and re-run CI.

rgerhards commented 1 year ago

Thx again for the PR! Much appreciated.

Yashinde145 commented 1 year ago

Thanks for checking and accepting PR!