search

rsyslog / rsyslog-pkg-rhel-centos

Package build sources for building RHEL/CentOS packages
17 stars 27 forks source link

Include omrabbitmq by default for el7? #56

Open dave-lew99 opened 5 years ago

dave-lew99 commented 5 years ago

Would it be possible to have the rabbitmq output module included in the default RPM builds for el7/CentOS7 and published in the adiscon repo?

We have been building our own RPMs up until now but it's awkward to manage and we need to re-build every time there is a new version or we get conflicts with the standard CentOS repos.

Thanks

rgerhards commented 5 years ago

I think it boils down if you would like to give a helping hand ;-) Please also consider OBS, as we are trying to move towards it.

davidelang commented 5 years ago

On Wed, 12 Jun 2019, dave-lew99 wrote:

Would it be possible to have the rabbitmq output module included in the default RPM builds for el7/CentOS7 and published in the adiscon repo?

since omrabbitmq would have a dependency on rabbitmq being installed, this probably shouldn't be in the base package, but it would make sense for it to be built as a seperate package (as we do with some others)

David Lang

dave-lew99 commented 5 years ago

Sorry if i'm a bit wrong on the terminology - yes a separate sub-package is ideal (and that's the way we're building it now).

In the current version it seems to be a flag at the top of the spec file (rsyslog-CentOS_7.spec) - but i don't know the reasons that it's disabled on versions >=7

I was trying to get rpmmaker going, but i've run into the same issues as https://github.com/rsyslog/rsyslog-pkg-rhel-centos/issues/47

dave-lew99 commented 5 years ago

I've created an OBS branch :)

I've made the single-character change (want_rabbitmq 0 => 1) and built, published and installed. Are there any concerns about having this enabled or was it just platform preference for it to be disabled?

https://build.opensuse.org/project/show/home:davelewthwaite:branches:home:rgerhards

Thanks

dave-lew99 commented 5 years ago

I suppose the question is, are you happy if i submitted this change back in OBS?

rgerhards commented 5 years ago

Sry, busy, but now had a look. I think we need to split the module to its own subpackage. The reason is that I assume it will create additional dependencies (those for rabbitmq). Also, I don't see them added to the package. There may be two reasons for that

  1. we may accidentally already have added them to the core project (without need)
  2. they may not be necessary for building, but the resulting package is not usable

Can you investigate? Once this is straight, I am more than happy to include it in the OBS build. We hope to be able to build a community of contributors around packaging.