rszimm / sprinklers_pi

Sprinkling System Control Program for the Raspberry Pi
GNU General Public License v2.0
310 stars 100 forks source link

Weather Adjustment of 0% not logged / not visible in Log Table #119

Open Dalmapalma opened 6 years ago

Dalmapalma commented 6 years ago

Hi all,

I just started to setup my sprinkler PI and everything is working so far (as expected). In the beginning I struggled a lot that some schedule were not running. At the end I figured out that this was due to the weather adjustment as the scale was set to 0%. 👍 But this case was not displayed in the log table.

Is there a way also to add this to the log table?

Thanks in advance and kind regards

nhorvath commented 6 years ago

Since the log just keeps track of actual run times I'm not sure how that would be done.

On Tue, Jun 5, 2018, 3:10 AM Dalmapalma notifications@github.com wrote:

Hi all,

I just started to setup my sprinkler PI and everything is working so far (as expected). In the beginning I struggled a lot that some schedule were not running. At the end I figured out that this was due to the weather adjustment as the scale was set to 0%. 👍 But this case was not displayed in the log table.

Is there a way also to add this to the log table?

Thanks in advance and kind regards

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rszimm/sprinklers_pi/issues/119, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKE3Krw4BBH1YWaBx7ns2YHluV9H364ks5t5i7KgaJpZM4UaRDJ .

Dalmapalma commented 6 years ago

What about to track just the duration = 0 and weather adjust = 0? So it would be easier to understand why it did not run... for example when I'm on vacation I would like to check the log and see why some schedules did not run.

taHC81 commented 5 years ago

Hi Dalmapalma, if you would like to have logged even the zero runtimes, please modify core.cpp 's LoadSchedTimeEvents.

https://github.com/rszimm/sprinklers_pi/blob/7e056511c3dc81e3e3f89c16e86aaaf901d7456f/core.cpp#L288

...and remove && (sched.zone_duration[k] > 0)

taHC81 commented 5 years ago

Now I realized it has small disadvantage - it reports zero runtimes even for ones in a schedule with 0 minutes intentionally. Like if you have 6 zones and schedule to run zone 2 for few minutes only and remaining ones are zero/off, you'll get logged all of them, even if they are not supposed to run.

fernplant commented 3 years ago

Having the same issue with 0% weather adjustment and being confused about the situation. Would be great to have a log entry to help with any confusion

nhorvath commented 3 years ago

To diagnose it you would be better off looking at the log file to see the weather calculation.

On Sun, Apr 25, 2021, 7:33 PM fernplant @.***> wrote:

Having the same issue with 0% weather adjustment and being confused about the situation. Would be great to have a log entry to help with any confusion

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rszimm/sprinklers_pi/issues/119#issuecomment-826414430, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABIJXFFH4QMP7NAFF34KADTKSREHANCNFSM4FDJCDEQ .