search

rszimm / sprinklers_pi

Sprinkling System Control Program for the Raspberry Pi
GNU General Public License v2.0
310 stars 100 forks source link

WeatherAdjust not working #121

Closed Dalmapalma closed 5 years ago

Dalmapalma commented 6 years ago

Hi,

I just have the issue that the Overall scale is not considered for the defined schedules. For example today...regarding the weather diagnostics, the overall scale is 67%.

In my Schedule the WeatherAdjust is enabled. But it is not "used"...that means when my scheduler started it used 100% instead of 67%.

Dalmapalma commented 6 years ago

this morning the same case...overall scale is 0% (as there was a lot of rain yesterday), and my schedule still took 100%, even with weatheradjust on.

nhorvath commented 6 years ago

You need to post logs and your wunderground settings.

On Thu, Jun 7, 2018, 4:00 AM Dalmapalma notifications@github.com wrote:

this morning the same case...overall scale is 0% (as there was a lot of rain yesterday), and my schedule still took 100%, even with weatheradjust on.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rszimm/sprinklers_pi/issues/121#issuecomment-395329407, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKE3Ap1RRWDbA04H8bXEBkag1mxLLjcks5t6N2YgaJpZM4UcVcq .

Dalmapalma commented 6 years ago

Can you just tell me how to get the logs?

nhorvath commented 6 years ago

https://github.com/rszimm/sprinklers_pi/wiki/File-locations#log-files

Dalmapalma commented 6 years ago

ok I checked the file...Looks that there was bad wu request..But why is it working sometimes and sometimes not? Here is the log for the schedule at 8am `2018/06/07 08:00:00 Trying to connect to:api.wunderground.com 2018/06/07 08:00:00 Resolved api.wunderground.com to:23.210.254.130

2018/06/07 08:00:00 Connected

2018/06/07 08:00:10 Client Disconnected

2018/06/07 08:00:10 Bad WUnderground Response

2018/06/07 08:00:10 Turning on Zone 1

2018/06/07 08:11:00 Turning Off All Zones

`

and this is my configuration for WU Wunderground Type: PWS ZIP: 0 PWS ID: IBADENWR156 Port 80 API key is entered.

Can I optimize it somehow?

nhorvath commented 6 years ago

Unfortunately wunderground has neglected its api and is actually not giving out keys anymore. In the long term it needs to be replaced. I may look into some caching and error checking in the mean time.

On Thu, Jun 7, 2018, 2:57 PM Dalmapalma notifications@github.com wrote:

ok I checked the file...Looks that there was bad wu request..But why is it working sometimes and sometimes not? Here is the log for the schedule at 8am 2018/06/07 08:00:00 Trying to connect to:api.wunderground.com 2018/06/07 08:00:00 Resolved api.wunderground.com to:23.210.254.130 2018/06/07 08:00:00 Connected 2018/06/07 08:00:10 Client Disconnected 2018/06/07 08:00:10 Bad WUnderground Response 2018/06/07 08:00:10 Turning on Zone 1 2018/06/07 08:11:00 Turning Off All Zones

and this is my configuration for WU Wunderground Type: PWS ZIP: 0 PWS ID: IBADENWR156 Port 80 API key is entered.

Can I optimize it somehow?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rszimm/sprinklers_pi/issues/121#issuecomment-395528580, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKE3LLLmsHf6cNLp1zOqFjY4ZwqT1Shks5t6XeogaJpZM4UcVcq .

Dalmapalma commented 6 years ago

I think caching as a short-term workaround would be good. I tested it today several times...My observation is that around 30-40% of requests result in bad response. I would assume that if 1-2 requests per today are successfull this should be already enough to calculate the weather scale and to have it cached for the whole day.

TheFuzz4 commented 6 years ago

I too can confirm the bad response from wunder

srthimsen commented 6 years ago

Another thought would be for weather requests to happen 3-4 times in the hour leading up to a scheduled start. Cache those attempts and use the most recent successful grab to make adjustments.

But as nhorvath also mentioned, since WU stopped giving out free API's (partially thanks to Big Blue buying them out and pulling the data into Watson), another service will be needed soon. Just glad it works at all, thanks to grabbing an API key years ago.