rszimm / sprinklers_pi

Sprinkling System Control Program for the Raspberry Pi
GNU General Public License v2.0
309 stars 100 forks source link

Duration solution #156

Closed Whytehorse closed 4 years ago

Whytehorse commented 4 years ago

If you allow the user to input hours:minutes for the duration of a schedule it would solve the problem of a 100 minute limit. the limit resides in the css in /sprinklers_pi-1.4.0/web/jquery/jquery.mobile-1.4.5.min.css

Just having a field for hr and mins would fix that. I get to wake up at midnight and turn on my sprinklers manually to get through the frost because I can't just schedule it to turn on all zones for 8hrs starting at midnight.

taHC81 commented 4 years ago

Hey, if you really want 8 hrs runtime from midnight, why you simply won't schedule it via cron & direct GPIO manipulation? :)

nhorvath commented 4 years ago

The internal data structure and scheduler uses an integer number of minutes. This would require a significant rewrite with changes that would break upgrades for existing users. The 100 min limit was increased to 254 minutes I believe. Anything beyond that is out of scope. Just use cron and gpio command line. Or fork this project and change it yourself.

On Thu, Oct 10, 2019, 2:12 AM taHC81 notifications@github.com wrote:

Hey, if you really want 8 hrs runtime from midnight, why you simply won't schedule it via cron & direct GPIO manipulation? :)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rszimm/sprinklers_pi/issues/156?email_source=notifications&email_token=AABIJXAGJ4WLUUR7RBFMDEDQN3BWTA5CNFSM4I7G3H7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA24OXA#issuecomment-540395356, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABIJXE7VVEGGC2SGH3MG2TQN3BWTANCNFSM4I7G3H7A .

nhorvath commented 4 years ago

I just double checked and yes it was increased to 255 in 1.4.1. If you're intent on running for 8 hours you could just have 2 240 min (4 hour) runtimes back to back in the same schedule.