search

rszimm / sprinklers_pi

Sprinkling System Control Program for the Raspberry Pi
GNU General Public License v2.0
309 stars 100 forks source link

OpenWeather Issues + Met Office DataPoint API (Free use and API Key available) #170

Closed cebab54 closed 4 years ago

cebab54 commented 4 years ago

Hi

I live in the UK and have tried to set up OpenWeather. I have an API which I have entered and saved in Settings and also established and set a named location "Beckenham,GB". This works in the OpenWeather website as a location, but when I try to retrieve test data in the Sprinklers Advanced Settings, the response is simply: "Invalid Response from Weather Provider server!"

Am I doing something wrong?

This always used to work when I used WunderGround, but now the API has been updated, the integration with Sprinklers_pi is broken and really needs retiring, unless it is going to be rewritten?

Here in the UK the Met Office also provide an API with free Weather data available to all - see https://www.metoffice.gov.uk/services/data/datapoint - would it be possible to use this API as a source of free data for Sprinklers_Pi as well as the other Weather API's listed?

Thanks

nhorvath commented 4 years ago

As the setup instructions state: Fill in Location in the format: latitude,longitude (eg. "40.749748,-73.991618")

Wunderground as we knew it went away and won't be coming back unless someone who has a private API key for it rewrites it and submits it. I have no interest in supporting their new closed API.

Met Office would require writing an adapter class to connect to their API and parse the data. That's assuming they even provide the data we need (yesterday's actual and today's forecast weather). https://github.com/rszimm/sprinklers_pi/blob/master/DEV_WEATHER.md

cebab54 commented 4 years ago

Hi Nick

It was the Location that threw me as a prompt, especially as it seems the website location resolves to a place name and or Zip code.

Maybe the Prompt on the Settings page for this provider should say “Loc’n Coords” or “Loc’n Lat,Long “ ??

Anyway now I have set the Lat and Longitude coordinates, the data is now retrieved correctly. Many thanks for your assistance.

The Met Office data is part of the UK Open Government data, similar to the Open Data for Ordnance Survey Maps and otherwise Public Transport movements. I will investigate what is available.

Still think that as the WunderGround API key no longer works, then the WIKI pages need to be updated and all references to the redundant API should now be removed. It worked well when I first instigated the Sprinklers_pi to irrigate my garden a few years back.

Andrew

From: Nick Horvath notifications@github.com Sent: 01 June 2020 15:31 To: rszimm/sprinklers_pi sprinklers_pi@noreply.github.com Cc: Andrew Hudson andrew.hudson@ashtenltd.com; Author author@noreply.github.com Subject: Re: [rszimm/sprinklers_pi] OpenWeather Issues + Met Office DataPoint API (Free use and API Key available) (#170)

As the setup instructions state: Fill in Location in the format: latitude,longitude (eg. "40.749748,-73.991618")

Wunderground as we knew it went away and won't be coming back unless someone who has a private API key for it rewrites it and submits it. I have no interest in supporting their new closed API.

Met Office would require writing an adapter class to connect to their API and parse the data. That's assuming they even provide the data we need (yesterday's actual and today's forecast weather). https://github.com/rszimm/sprinklers_pi/blob/master/DEV_WEATHER.md

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/rszimm/sprinklers_pi/issues/170#issuecomment-636893208, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHDPYJQSLJS4NNJK57SH5BTRUO3QNANCNFSM4NP2YKBQ.