search

rszimm / sprinklers_pi

Sprinkling System Control Program for the Raspberry Pi
GNU General Public License v2.0
309 stars 100 forks source link

Added a Weather Provider for OPEN WEATHER V3.0 #191

Closed keithfisher123 closed 2 months ago

keithfisher123 commented 1 year ago

Full disclosure - I do not know C++ so I mostly copy and edit the original to make it work... I made a new provider copying all the OPENWEATHER classes and making a few edits. I was going to edit the original but my thought is that folks who have 2.5 version of API will still need that one to be like it was for 2.5 NEW accounts at OpenWeather only bet APIs for v3.0 So I changed the URL and also some code where it parses out the data. In v3.0 the time machine option works a bit dif in that the data doesn't have an Hourly just a data section. I may have misunderstood BUT I think this seems to work for me...

keithfisher123 commented 1 year ago

Hmm - now that I am playing with it some more it seems like the today and yesterday values are reversed

jjpd19 commented 9 months ago

I have no idea about C++ so I cannot help with this. I am getting the error "Bad OpenWeather Response". I don not know if the problem is how I am typing the location textbox (I am using "LOCATION,COUNTRY CODE"), or what but I am getting this error.

nhorvath commented 9 months ago

For Openweather i believe you have to specify gps coordinates in decimal format. Latitude,Longitude

On Sat, Oct 7, 2023 at 12:46 PM jjpd19 @.***> wrote:

I have no idea about C++ so I cannot help with this. I am getting the error "Bad OpenWeather Response". I don not know if the problem is how I am typing the location textbox (I am using "LOCATION,COUNTRY CODE"), or what but I am getting this error.

— Reply to this email directly, view it on GitHub https://github.com/rszimm/sprinklers_pi/pull/191#issuecomment-1751767116, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABIJXCP33SNEYLGW6ZWWGDX6GBNNAVCNFSM572DY5Y2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCNZVGE3TMNZRGE3A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

nhorvath commented 2 months ago

merging to ow3 branch to test and finish work.

ThomasDtz commented 2 months ago

Hi Nick,

do you plan to take the modifications for OpenWeather 3.0 from branch ow3 to master?

Thomas

Von: Nick Horvath @.> Gesendet: Sonntag, 21. April 2024 17:06 An: rszimm/sprinklers_pi @.> Cc: Subscribed @.***> Betreff: Re: [rszimm/sprinklers_pi] Added a Weather Provider for OPEN WEATHER V3.0 (PR #191)

Merged #191 https://github.com/rszimm/sprinklers_pi/pull/191 into ow3.

— Reply to this email directly, view it on GitHub https://github.com/rszimm/sprinklers_pi/pull/191#event-12551104674 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AQPWBJN6ROJ5MQAKNK4QNLDY6PIUPAVCNFSM572DY5Y2U5DIOJSWCZC7NNSXTWQAEJEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW4OZRGI2TKMJRGA2DMNZU . You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/AQPWBJKPWP5FBHIUBDF2OQ3Y6PIUPA5CNFSM572DY5Y2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGPAAAAAAXMDKUKE.gif Message ID: @. @.> >

-- Diese E-Mail wurde von AVG-Antivirussoftware auf Viren geprüft. www.avg.com

nhorvath commented 2 months ago

They aren't correct. I was working on it but needed to look up some rain and got busy.

ThomasDtz commented 2 months ago

Ok thanks for your andereAm 02.05.2024 um 21:04 schrieb Nick Horvath @.***>: They aren't correct. I was working on it but needed to look up some rain and got busy.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>