search

rszimm / sprinklers_pi

Sprinkling System Control Program for the Raspberry Pi
GNU General Public License v2.0
310 stars 100 forks source link

Prefer to create zones as needed instead of fixed at 15 #3

Closed KanyonKris closed 10 years ago

KanyonKris commented 11 years ago

I'd prefer to create zones like schedules - one at a time as needed. I only have 3 zones so I'd rather just see 3 zones listed instead of fixed at 15.

At least visually differentiate the enabled and disabled zones (greyed out or something).

rszimm commented 11 years ago

The only place you should see disabled zones is in the Zones page. Everywhere else they should not appear. If you still seem them, perhaps you upgraded from a previous version and didn't clear your browser cache? Or maybe there's a bug. Could you give me a bit more feedback?

KanyonKris commented 11 years ago

I wasn't very clear, my apologies. I was speaking only of the Zones page. And this is a feature request, not a bug report. I just feel it would be cleaner to only show enabled zones on the Zone page and have an "Add" button to create new zones, like you do with creating new schedules. But I understand your choice to display 15 because that is the limit and it communicates to the use how many zones are available (if the hardware is there to support it). As a compromise, I suggest changing the Zones page to show enabled zones as they are now, and "grey out" or otherwise visually mute the disabled zones so when the user goes to the Zones page it's clear at a glance which zones are enabled. Just saves clicking on and expanding zones to see if the Enabled box is checked or not. And for the record, good work on this program! You've done good work here, I like how it works.

rszimm commented 11 years ago

Thanks. I hear what you're saying. I was a bit alarmed when I increased the number of zones up to 15. However, I'm thinking that this page only really gets accessed the very first time you configure your system. After that there's relatively little reason to ever go back to the zone page. I'm thinking I'll keep this issue open and tackle it if I ever need to rip apart the zone page (or if I decide to enable more than one expansion board).

KanyonKris commented 11 years ago

Makes sense and I agree. I may tinker with the Zones page javascript to see what I can come up with, mostly because I need a project to help me learn this new world of web (javascript, jquery, JSON, AJAX, etc.). If I come up with something I like I'll send it to you for consideration.