rszimm / sprinklers_pi

Sprinkling System Control Program for the Raspberry Pi
GNU General Public License v2.0
310 stars 100 forks source link

When running zone manually "run schedule" is set to off #69

Closed frelev closed 7 years ago

frelev commented 8 years ago

When starting a zone manually sprinkler_pi changes "run schedule" to off Is this by design?

I often run sprinklers manually and sometimes forget to add "run schedule" to on again. Would prefer if "run scheduled" was still on On even if a zone is started manually

piesio98 commented 7 years ago

Same problem with the same history in here. Can't locate a file where that function is. Just pls tell where and how to change it.

alessandro-dallatorre commented 7 years ago

Same problem, I just got used to it but I find it dangerous, especially when manually checking if the plant works before leaving for holidays!! I had a quick look and would suggest commenting line 69 in file core.cpp, building (./make) and restarting (./sudo make upgrade).

For the time being I have not checked it myself, so I do not guarantee it solves the problem, but you can try and let me know!

Cheers, Alex

void runStateClass::SetManual(bool val, int8_t zone) { LogSchedule(); //I would try commenting line below, sounds like the guilty one //m_bSchedule = false;

alessandro-dallatorre commented 7 years ago

Hi,

I check on the proposed changed but it does not solve the issue. I will search in the code elsewhere.

Regards, Alessandro

alessandro-dallatorre commented 7 years ago

Hi,

I found it!!!

Comment line 453 in file web.cpp, then build (./make) and restart (./sudo make upgrade). Schedules nowvstay active after running zone manual

static bool ManualZone(const KVPairs & key_value_pairs) { freeMemory();

// Turn off the current schedules.

//SetRunSchedules(false);

piesio98 commented 7 years ago

That so cool,i'll make this vhange after i return home. Thank u so much for so much diging in those files

toshibochan commented 7 years ago

Hope can fix the problem!

alessandro-dallatorre commented 7 years ago

It actually did for me. Try yourself and let me know!

piesio98 commented 7 years ago

i commented that line(in home/pi/wirringPi/sprinklers_Pi), but how to update it. i don't understand this "then build (./make) and restart (./sudo make upgrade).".

nhorvath commented 7 years ago

Follow the upgrade instructions on the wiki but skip the download/extract the new version part. https://github.com/rszimm/sprinklers_pi/wiki/Upgrading

On Tue, Jun 6, 2017 at 10:56 AM, piesio98 notifications@github.com wrote:

i commented that line, but how to update it. i don't understand this "then build (./make) and restart (./sudo make upgrade).".

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rszimm/sprinklers_pi/issues/69#issuecomment-306512660, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKE3LOeEequZvsnQm5CtirOrqHZVP8eks5sBWiwgaJpZM4JLZpc .

piesio98 commented 7 years ago

OK! it works ! thanks

nhorvath commented 7 years ago

Fixed in v1.1.0