search

rszimm / sprinklers_pi

Sprinkling System Control Program for the Raspberry Pi
GNU General Public License v2.0
310 stars 100 forks source link

min max not declared #96

Closed vliegher closed 7 years ago

vliegher commented 7 years ago

when installing I got a prompt that min and max in weather.cpp were not declared. installation stopped. How do I proceed?

nhorvath commented 7 years ago

Make sure you have followed all the steps here: https://github.com/rszimm/sprinklers_pi/wiki/Installation

If it still fails then please attach a log of the console.

On Sat, Aug 19, 2017 at 7:01 AM, vliegher notifications@github.com wrote:

when installing I got a prompt that min and max in weather.cpp were not declared. installation stopped. How do I proceed?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rszimm/sprinklers_pi/issues/96, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKE3KN9h08SiXvg50rWi1nXA4Vx3Di7ks5sZsCVgaJpZM4O8TQ6 .

vliegher commented 7 years ago

I tried it again. This is the point it goes wrong.

Op 19 aug. 2017, om 15:43 heeft Nick Horvath notifications@github.com het volgende geschreven:

Make sure you have followed all the steps here: https://github.com/rszimm/sprinklers_pi/wiki/Installation

If it still fails then please attach a log of the console.

On Sat, Aug 19, 2017 at 7:01 AM, vliegher notifications@github.com wrote:

when installing I got a prompt that min and max in weather.cpp were not declared. installation stopped. How do I proceed?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rszimm/sprinklers_pi/issues/96, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKE3KN9h08SiXvg50rWi1nXA4Vx3Di7ks5sZsCVgaJpZM4O8TQ6 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rszimm/sprinklers_pi/issues/96#issuecomment-323523967, or mute the thread https://github.com/notifications/unsubscribe-auth/AdtuHhkPg16ELAhDVOhtlz8vwJBqJPT8ks5sZuaRgaJpZM4O8TQ6.

vliegher commented 7 years ago

It seems to be a c++compiler issue but i fixed it. Used std::min and std::max instead of min and max. Also some incompatibility between integer and long integer. Fixed that as well. It's working......

toshibochan commented 6 years ago

I change in port.h but no work. please help

ifndef std::max

define max(a,b) (((a) > (b)) ? (a) : (b))

endif

ifndef std::min

define min(a,b) (((a) < (b)) ? (a) : (b))