search

rszyma / kanata-tray

Tray Icon for Kanata
GNU General Public License v3.0
65 stars 1 forks source link

Add macOS support #17

Closed guruor closed 7 months ago

guruor commented 7 months ago

Changes needed for https://github.com/rszyma/kanata-tray/issues/16 building on macos.

rszyma commented 7 months ago

  1. Does macos require any dependencies? If yes please add them to readme.

  2. It would be nice to add macos to CI (see https://github.com/rszyma/kanata-tray/tree/main/.github/workflows)

guruor commented 7 months ago

Does macos require any dependencies? If yes please add them to readme.

I did not require any dependencies so can't commit if any was pre-requisite, will have to try it on a fresh system.

It would be nice to add macos to CI (see https://github.com/rszyma/kanata-tray/tree/main/.github/workflows)

Let me try adding the workflow, it will help us determine if any dependency is required.

rszyma commented 7 months ago

Let me try adding the workflow, it will help us determine if any dependency is required.

There won't be any build time dependency, I rather thought about runtime dependency (look at linux dependencies in readme, these are runtime ones).

Using ldd might help https://stackoverflow.com/a/6589958/9611188. Though there's no pressure to find out the required libraries now, they can be added later to readme.

rszyma commented 7 months ago

I wanted to see the what's the error with cross-compiling https://github.com/rszyma/kanata-tray/actions/runs/8730443667/job/23954275895

Let's just use your solution.

Thanks for the PR :)