rt-2 / CZUL-Scope-Files

Package for CANscope(EuroScope) covering the Virtual Montréal FIR
2 stars 2 forks source link

PUT ATIS BACK #339

Open Mistadouf opened 4 years ago

Mistadouf commented 4 years ago

Need to keep ATIS, Euroscope needs to read ATIS files to push ATIS letter to other controllers. AFV will bring back possibility to use .WAV files for atis.

rt-2 commented 4 years ago

Some people use the bilingual ATIS, some people use the old ATIS. Both should be taken into account for this (Only the english version is needed for the bilingual, it doesn't try to play the french part)

rt-2 commented 4 years ago

You are uploading real .wav files, this is extremly uneffective. Euroscope will not play those files for pilot, it seems like we must put a 0 byte (or 1 byte) file instead of 'real' sounds. Also, I will investigate what file do we need for the bilingual ATIS

rt-2 commented 4 years ago

We CAN refer to any character to the same file, so basicaly all we need to do is have ONE 1 byte (or 0 byte) WAV file, and in the config, ALL characters refer to that file. (no need to add 1 file per syllable)

rt-2 commented 4 years ago

I took the liberty to modify your branch (easier and simpler than creating a new one etc.) If there is any problem we can just revert

rt-2 commented 4 years ago

Use 1 empty file instead of real sounds

https://github.com/rt-2/CZUL-Scope-Files/commit/6fd01e34f3a3008d955c8389417ca59d82abd365

Tested, will not give any error when creating an ATIS

rt-2 commented 4 years ago

Removed seemingly useless files

https://github.com/rt-2/CZUL-Scope-Files/commit/c7940989b4dd8e9ee00a0d1670ea7b0e4841672a

Not tested, pretty sure it'll be OK

rt-2 commented 4 years ago

Added compatibility for 'Bilingual ATIS'

https://github.com/rt-2/CZUL-Scope-Files/commit/1c5e3b46869dd7f136c0a3cdd45a26fa5ac60999

This should cover all needed, tested

rt-2 commented 4 years ago

I took the liberty to modify your branch (easier and simpler than creating a new one etc.) If there is any problem we can just revert. MUST TEST:

What do you think of that?