search

rt-bishop / Look4Sat

Open-source satellite tracker and pass predictor for Android, inspired by Gpredict
https://play.google.com/store/apps/details?id=com.rtbishop.look4sat
GNU General Public License v3.0
612 stars 58 forks source link

Antenna Rotor Control #121

Open Gustyarte opened 9 months ago

Gustyarte commented 9 months ago

Thank you very much for such an excellent application; it is truly beautiful and accurate so far!

I would like to report that the commands for controlling an antenna rotor are not the same as Gpredict. Therefore, the rotor does not respond to the commands or executes them incorrectly. For example, in Gpredict, the command sent is P 114.80 14.00, while in your application, it is set_pos 114.8 14.0. This subtle difference (at least the one I observed) causes it not to work.

I'm not sure if there is a standard for the rotctl protocol, but I would love to be able to use your application instead of a computer.

Thank you!

EeeLo commented 9 months ago

You can just edit the control file to change that

rt-bishop commented 8 months ago

Hey @Gustyarte! I'm sorry for such a slow response. According to ROTCTL docs both short and long command names should be fine to use, so I never thought it can lead to an issue. But you're right, GPredict uses the short naming convention, which I somehow overlooked. I should probably change that just so both apps are aligned.

rt-bishop commented 6 months ago

Hey @Gustyarte. In the recent build v3.1.4 I've aligned the rotctl command with what's being sent by Gpredict, so in your case it should work out of the box. It's currently being reviewed by Google. Hopefully it won't break anyone else's implementation =)