search

rt-bishop / Look4Sat

Open-source satellite tracker and pass predictor for Android, inspired by Gpredict
https://play.google.com/store/apps/details?id=com.rtbishop.look4sat
GNU General Public License v3.0
643 stars 63 forks source link

azimuth usage in getRangeCircle() #133

Open Raviu56 opened 5 months ago

Raviu56 commented 5 months ago

For azimuth in getRangeCircle() under class SatPos This line val rads = azimuth * DEG2RAD converts it to RAD while everything in SatPos in already in radians. A hint should be added to the class, or a rename of variables to indicate that everything here is in radians. This also applies to devel branch where the class is now renamed to OrbitalPos

rt-bishop commented 5 months ago

Hey there! Thanks so much for this suggestion. The actual position calculation code was taken as is from predict4java only converted from java into kotlin. Currently I don't have time to keep on working on this project as I've recently became a daddy. Once things stabilize, my daughter grows up a bit and I finally get some sleep which I assume will happen in a few months I'll get back to the project with the intention to finish the miration to Compose UI. A lot of code has been refactored in devel branch and I do have plans to continue cleaning things up.