Valid Locators Are Not Accepted

rt-bishop / Look4Sat

Open-source satellite tracker and pass predictor for Android, inspired by Gpredict

https://play.google.com/store/apps/details?id=com.rtbishop.look4sat

GNU General Public License v3.0

613 stars 58 forks source link

Valid Locators Are Not Accepted #44

Closed DC7IA closed 3 years ago

DC7IA commented 3 years ago

Hi,

some locators aren't accepted by Look4Sat. It says they are "invalid".

Version: 2.0.1 Locator: JO51BJ

DC7IA commented 3 years ago

Weirdly enough, it worked a few minutes later for me.

@Konradrundfunk is the original observer of this bug

DC7IA commented 3 years ago

Alright, I narrowed it down to being upper-case. While JO51BJ does not work, JO51bj does.

DC7IA commented 3 years ago

Look4Sat should tell users how to type the locator or ignore case, imho.

Konradrundfunk commented 3 years ago

It seams to me that the funktion setPositionFromQth in the class Prefsfragment is stricktly set to thoose values.

rt-bishop commented 3 years ago

Hey everyone and thanks for reporting this! To be honest I didn't expect the letter case to be such an issue for so many users. I'll definitely fix it with the next update, so the case will be converted internally, accepting those wrongly "invalid" locators. Will also create some unit tests to cover this issue.