search

rt2zz / redux-persist-crosstab

Keep redux browser tab state in sync
85 stars 27 forks source link

Whitelist support #2

Closed alecmev closed 9 years ago

alecmev commented 9 years ago

Was about to request whitelist support in the parent project, but @grabbou beat me to it :)

In the linked issue you said:

My hesitation is that I have yet to see an app that would whitelist more than it would blacklist.

I think it's the opposite in this case, since cross-tab syncing is so sensitive to race conditions (at least with the current implementation). Mimicking redux-persist in this matter is the obvious solution.

grabbou commented 9 years ago

Ha! +1

rt2zz commented 9 years ago

just added whitelist https://github.com/rt2zz/redux-persist-crosstab/commit/17d659ff06afe4428cd71baeed4c62d5f83ece51

I have not tested it at all, so not going to npm publish yet. If possible install from git and let me know if that works for you.

alecmev commented 9 years ago

I don't have any frontend tests yet myself, but this seems to be working fine in my setup. The code is logically sound too :) Should be okay to publish. Thanks.

rt2zz commented 9 years ago

just published 1.0.1