search

rt2zz / redux-persist-crosstab

Keep redux browser tab state in sync
85 stars 27 forks source link

Ensure localStorage is not fired in the source window with IE9/10 #3

Open thisiskylierose opened 9 years ago

thisiskylierose commented 9 years ago

HTML5 localStorage implementation in IE 9/10 does not match the spec. This is a known issue and the pull request addresses a work-around. Please test and feedback any changes required. See link below for more details on the problem.

https://connect.microsoft.com/IE/feedback/details/774798/localstorage-event-fired-in-source-window

rt2zz commented 9 years ago

@thisiskylierose why did you close?

thisiskylierose commented 9 years ago

I need to do some more testing on the changes first.

thisiskylierose commented 9 years ago

Please have a look now - have tested these changes more with redux in a build and it seems to be working well. Need to run tests in IE9/10 to make sure those browsers play nice. :)

thisiskylierose commented 9 years ago

Dev branch has console logs: https://github.com/thisiskylierose/redux-persist-crosstab/tree/development

aij commented 8 years ago

This seems to be assuming the focused window is the source window. While that may be true for your specific application, it is not true in general.

For example, we sometimes trigger redux updates as a result of an HTTP response, which may come in while a different window/tab is in focus.