search

rt400 / Jewish-Sabbaths-Holidays

Jewish Shabbat Yomtov and Holidays times and event
9 stars 1 forks source link

Isur melacha sensor #12

Closed aviadlevy closed 2 years ago

aviadlevy commented 2 years ago

I understand and love the separation you made between shabbat and yomtov, and it's indeed helpful. Still, I sometime do find myself adding "and" condition that checking if it's not shabbat and not yomtov. Do you think there is a place to another sensor represent this condition (isur melacha or whatever other name you'll decide to call it)

If so, I would love to try and open a PR for this change and contribute

Thanks

rt400 commented 2 years ago

cant make sensor for shabbat and yomtov together cause in there is no data for yomtov (data like the datetime variable) and cant run with it in the function and can raise an exception.