rt400 / Jewish-Sabbaths-Holidays

Jewish Shabbat Yomtov and Holidays times and event
9 stars 1 forks source link

Jerusalmem candle light #13

Closed lidans5 closed 1 year ago

lidans5 commented 1 year ago

When adding: jerusalem_candle: True to the yaml configuration file the integration stops working

rt400 commented 1 year ago

change the True to true and check it plz

lidans5 commented 1 year ago

didn't help when adding jerusalem... all entities are gone

rt400 commented 1 year ago

plz share your config in code mode

lidans5 commented 1 year ago

do you mean configuration.yaml file? (the heb is on sensors.yaml)

rt400 commented 1 year ago

the sensor config

lidans5 commented 1 year ago

- platform: hebcal
  havdalah_calc: 42
  time_before_check: 10
  time_after_check: 1
  tzeit_hakochavim: False
  omer_count_type: 0
  # jerusalem_candle: true
  resources:
    - shabbat_in
    - shabbat_out
    - parasha
    - hebrew_date
    - is_shabbat
    - yomtov_in
    - yomtov_out
    - is_yomtov
    - yomtov_name
    - event_name
    - omer_day
    - zmanim
rt400 commented 1 year ago

try this config :

- platform: hebcal
  havdalah_calc: 42
  time_before_check: 10
  time_after_check: 1
  tzeit_hakochavim: False
  omer_count_type: 0
  jerusalem_candel: True
  resources:
    - shabbat_in
    - shabbat_out
    - parasha
    - hebrew_date
    - is_shabbat
    - yomtov_in
    - yomtov_out
    - is_yomtov
    - yomtov_name
    - event_name
    - omer_day
    - zmanim

there is a proto type mistake, its should be jerusalem_candle but its jerusalem_candel i will check it in my code and fix it.

rt400 commented 1 year ago

I think that you may not have the last update... I see that I already fix that typo

lidans5 commented 1 year ago

I can't see any difference between your config and my and when verifying configuration, getting this message: Invalid config for [sensor.hebcal]: [jerualem_candle] is an invalid option for [sensor.hebcal]. Check: sensor.hebcal->jerualem_candle. (See ?, line ?).

rt400 commented 1 year ago

you got this error cause you in the version before the typo fix. try to use this jerusalem_candel: True and see if its work

lidans5 commented 1 year ago

" its should be jerusalem_candle but its jerusalem_candel" It should be jerusalem_candel - you meant indeed jerusalem candel works - Thanks!!!

rt400 commented 1 year ago

you should update to the last version cause i the last version is jerusalem_candle: True

lidans5 commented 1 year ago

no update available in my Hacs...

rt400 commented 1 year ago

which version you have?

lidans5 commented 1 year ago

2.0.8

rt400 commented 1 year ago

i make new version plz check it and fix the typo