rt400 / Jewish-Sabbaths-Holidays

Jewish Shabbat Yomtov and Holidays times and event
9 stars 2 forks source link

sensor.hebcal_is_yomtov returns "No Info" #18

Closed danielrosehill closed 7 months ago

danielrosehill commented 7 months ago

Current sensor condition for "is_yomtov" returns "No info".

Is the integration broken? (I assume it's supposed to be the same True/False flag as is_shabbat).

If not perhaps it could be changed to True/False for ease of use and configuring automations.

no info yom tov

rt400 commented 7 months ago

Hi, When you see "No Info" its means that there is no data... cause no yomtov in this week. Also you can set Hebrew is the integration and you will get "אין מידע". when HA goes up then the sensor "is_yomtov" is in "unknown" status and as soon as the integration updates the sensor information it becomes FALSE. So if you have an automation based on this TRUE/FALSE you might trigger it.

danielrosehill commented 7 months ago

@rt400 - Thanks for the info - and for developing this!

I wrote up a little blog last night about a little project I made using it (just a little light to indicate when Shabbat is in). This Shabbat, it will be powering a bunch of automations.

https://www.hackster.io/danielrosehill/a-simple-shabbat-indicator-light-using-home-assistant-842571

rt400 commented 7 months ago

Thanks.. You have to mistake :

  1. Fix jerusalem typo in code.
  2. My Name is Yuval Mejahez not Yuval Abolafia... (I am the writer of this integration ...) image
danielrosehill commented 7 months ago

Thanks.. You have to mistake :

  1. Fix jerusalem typo in code.
  2. My Name is Yuval Mejahez not Yuval Abolafia... (I am the writer of this integration ...) image

Will update!

danielrosehill commented 7 months ago

You have to mistake :

  1. Fix jerusalem typo in code.
  2. My Name is Yuval Mejahez not Yuval Abolafia... (I am the writer of this integration ...)

Both updated