search

rtCamp / action-wordpress-org-plugin-deploy

MIT License
4 stars 2 forks source link

Outdated PHP version #4

Open BrianHenryIE opened 4 years ago

BrianHenryIE commented 4 years ago

My build tools need a newer PHP version. It seems this is set in Docker Hub so I'm not sure how to PR for it.

mrrobot47 commented 4 years ago

What tool are you using? Which PHP version is required for it?

The main Dockerfile of the action is present here which uses the base image from here.

You can send a PR against these Dockerfiles. It will be great if you can send a PR for updating these to PHP 7.4.

BrianHenryIE commented 4 years ago

Here's my failed action

It seems I just need to edit the first line of the base image from 7.1 to 7.4 but I'm not familiar enough with Docker to make and test the change and confidently make a PR that many people might use.

mrrobot47 commented 4 years ago

Thanks for the reference error log. I will take a look into it, update it and get back to you over this issue.

mrrobot47 commented 4 years ago

@BrianHenryIE I have updated the PHP image. Also, updated node and composer alongside. Can you try this action now and let me know if it works?

I have not yet merged these changes to master, but have them updated in the develop branch of action, i.e.,

      uses: rtCamp/action-wordpress-org-plugin-deploy@develop

Keep rest of the workflow as it was, just update the action @master tag to @develop and try re-running it.